Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: repurpose --builder flag to alias maxprofit builder.selection and turn builder off by default #6081

Merged
merged 3 commits into from
Nov 3, 2023
Merged

refactor: repurpose --builder flag to alias maxprofit builder.selection and turn builder off by default #6081

merged 3 commits into from
Nov 3, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Nov 3, 2023

On some discussion and feedback turning the builder off by default on validator unless --builder.selection is provided explicitly or via the maxprofit alias --builder

this brings us more compatible to the previous use of the builder args on the validator with the builder off if no --builder & --builder.selection is provided.

however this flag is still optional and just an alias and can be ignored if an explicit --builder.selection is provided

@g11tech g11tech requested a review from a team as a code owner November 3, 2023 09:36
@g11tech g11tech changed the title refac: repurpose --builder flag to alias maxprofit builder.selection and turn builder off by default refactor: repurpose --builder flag to alias maxprofit builder.selection and turn builder off by default Nov 3, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

🚀🚀 Significant benchmark improvement detected

Benchmark suite Current: 7c13619 Previous: 618895c Ratio
altair processAttestation - 250000 vs - 7PWei normalcase 2.7255 ms/op 12.783 ms/op 0.21
altair processAttestation - 250000 vs - 7PWei worstcase 2.3829 ms/op 12.375 ms/op 0.19
Full benchmark results
Benchmark suite Current: 7c13619 Previous: 618895c Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 665.63 us/op 492.96 us/op 1.35
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 57.630 us/op 51.187 us/op 1.13
BLS verify - blst-native 1.1098 ms/op 1.1275 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 2.3940 ms/op 2.4156 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.2187 ms/op 5.3997 ms/op 0.97
BLS verifyMultipleSignatures 32 - blst-native 19.157 ms/op 19.694 ms/op 0.97
BLS verifyMultipleSignatures 64 - blst-native 40.617 ms/op 38.996 ms/op 1.04
BLS verifyMultipleSignatures 128 - blst-native 73.622 ms/op 77.032 ms/op 0.96
BLS deserializing 10000 signatures 765.76 ms/op 823.42 ms/op 0.93
BLS deserializing 100000 signatures 8.5224 s/op 8.2348 s/op 1.03
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.2429 ms/op 1.1410 ms/op 1.09
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.3559 ms/op 1.2891 ms/op 1.05
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.5120 ms/op 2.0193 ms/op 1.24
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8842 ms/op 3.0115 ms/op 1.29
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.0943 ms/op 4.9875 ms/op 1.02
BLS aggregatePubkeys 32 - blst-native 23.115 us/op 23.089 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 91.109 us/op 89.289 us/op 1.02
getAttestationsForBlock 36.495 ms/op 22.521 ms/op 1.62
isKnown best case - 1 super set check 313.00 ns/op 346.00 ns/op 0.90
isKnown normal case - 2 super set checks 316.00 ns/op 324.00 ns/op 0.98
isKnown worse case - 16 super set checks 323.00 ns/op 333.00 ns/op 0.97
CheckpointStateCache - add get delete 4.4790 us/op 3.7620 us/op 1.19
validate api signedAggregateAndProof - struct 2.5435 ms/op 2.4675 ms/op 1.03
validate gossip signedAggregateAndProof - struct 2.4658 ms/op 2.5021 ms/op 0.99
validate gossip attestation - vc 640000 1.2105 ms/op 1.1822 ms/op 1.02
batch validate gossip attestation - vc 640000 - chunk 32 149.45 us/op 138.52 us/op 1.08
batch validate gossip attestation - vc 640000 - chunk 64 138.48 us/op 123.92 us/op 1.12
batch validate gossip attestation - vc 640000 - chunk 128 128.52 us/op 118.23 us/op 1.09
batch validate gossip attestation - vc 640000 - chunk 256 118.39 us/op 114.97 us/op 1.03
pickEth1Vote - no votes 918.14 us/op 911.02 us/op 1.01
pickEth1Vote - max votes 9.2599 ms/op 7.0477 ms/op 1.31
pickEth1Vote - Eth1Data hashTreeRoot value x2048 16.247 ms/op 14.173 ms/op 1.15
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.941 ms/op 29.806 ms/op 0.87
pickEth1Vote - Eth1Data fastSerialize value x2048 396.40 us/op 478.38 us/op 0.83
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.7714 ms/op 3.6198 ms/op 1.59
bytes32 toHexString 433.00 ns/op 503.00 ns/op 0.86
bytes32 Buffer.toString(hex) 329.00 ns/op 304.00 ns/op 1.08
bytes32 Buffer.toString(hex) from Uint8Array 449.00 ns/op 438.00 ns/op 1.03
bytes32 Buffer.toString(hex) + 0x 340.00 ns/op 320.00 ns/op 1.06
Object access 1 prop 0.20900 ns/op 0.22000 ns/op 0.95
Map access 1 prop 0.19000 ns/op 0.20100 ns/op 0.95
Object get x1000 4.9630 ns/op 5.5820 ns/op 0.89
Map get x1000 0.58400 ns/op 0.53600 ns/op 1.09
Object set x1000 26.169 ns/op 25.956 ns/op 1.01
Map set x1000 17.778 ns/op 17.877 ns/op 0.99
Return object 10000 times 0.22750 ns/op 0.24230 ns/op 0.94
Throw Error 10000 times 2.7936 us/op 2.8726 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 1.9570 us/op 2.0260 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 316.00 ns/op 376.00 ns/op 0.84
fastMsgIdFn h64 xxhash / 200 bytes 344.00 ns/op 375.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 6.0770 us/op 6.0810 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 431.00 ns/op 483.00 ns/op 0.89
fastMsgIdFn h64 xxhash / 1000 bytes 402.00 ns/op 420.00 ns/op 0.96
fastMsgIdFn sha256 / 10000 bytes 51.433 us/op 54.295 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.8020 us/op 1.9340 us/op 0.93
fastMsgIdFn h64 xxhash / 10000 bytes 1.2700 us/op 1.2900 us/op 0.98
send data - 1000 256B messages 11.480 ms/op 16.177 ms/op 0.71
send data - 1000 512B messages 17.182 ms/op 18.252 ms/op 0.94
send data - 1000 1024B messages 24.912 ms/op 25.569 ms/op 0.97
send data - 1000 1200B messages 27.979 ms/op 27.020 ms/op 1.04
send data - 1000 2048B messages 32.383 ms/op 34.220 ms/op 0.95
send data - 1000 4096B messages 27.910 ms/op 28.406 ms/op 0.98
send data - 1000 16384B messages 79.870 ms/op 80.392 ms/op 0.99
send data - 1000 65536B messages 421.11 ms/op 402.37 ms/op 1.05
enrSubnets - fastDeserialize 64 bits 987.00 ns/op 1.3400 us/op 0.74
enrSubnets - ssz BitVector 64 bits 446.00 ns/op 574.00 ns/op 0.78
enrSubnets - fastDeserialize 4 bits 206.00 ns/op 283.00 ns/op 0.73
enrSubnets - ssz BitVector 4 bits 423.00 ns/op 528.00 ns/op 0.80
prioritizePeers score -10:0 att 32-0.1 sync 2-0 66.917 us/op 82.645 us/op 0.81
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 81.380 us/op 83.218 us/op 0.98
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 107.75 us/op 113.28 us/op 0.95
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 177.50 us/op 210.50 us/op 0.84
prioritizePeers score 0:0 att 64-1 sync 4-1 206.38 us/op 237.26 us/op 0.87
array of 16000 items push then shift 1.3461 us/op 1.3276 us/op 1.01
LinkedList of 16000 items push then shift 6.0130 ns/op 6.0610 ns/op 0.99
array of 16000 items push then pop 57.077 ns/op 70.253 ns/op 0.81
LinkedList of 16000 items push then pop 5.7890 ns/op 5.7870 ns/op 1.00
array of 24000 items push then shift 1.8830 us/op 1.9554 us/op 0.96
LinkedList of 24000 items push then shift 5.8490 ns/op 6.0310 ns/op 0.97
array of 24000 items push then pop 86.036 ns/op 131.04 ns/op 0.66
LinkedList of 24000 items push then pop 5.5820 ns/op 6.2370 ns/op 0.89
intersect bitArray bitLen 8 5.3530 ns/op 5.5450 ns/op 0.97
intersect array and set length 8 42.897 ns/op 46.869 ns/op 0.92
intersect bitArray bitLen 128 25.497 ns/op 26.989 ns/op 0.94
intersect array and set length 128 590.00 ns/op 639.77 ns/op 0.92
bitArray.getTrueBitIndexes() bitLen 128 1.0970 us/op 1.6490 us/op 0.67
bitArray.getTrueBitIndexes() bitLen 248 1.8050 us/op 2.4250 us/op 0.74
bitArray.getTrueBitIndexes() bitLen 512 3.3900 us/op 4.0410 us/op 0.84
Buffer.concat 32 items 828.00 ns/op 862.00 ns/op 0.96
Uint8Array.set 32 items 1.2860 us/op 1.4450 us/op 0.89
Set add up to 64 items then delete first 1.7371 us/op 1.7988 us/op 0.97
OrderedSet add up to 64 items then delete first 2.6625 us/op 2.7293 us/op 0.98
Set add up to 64 items then delete last 1.9762 us/op 2.0609 us/op 0.96
OrderedSet add up to 64 items then delete last 2.9470 us/op 3.3249 us/op 0.89
Set add up to 64 items then delete middle 1.9767 us/op 2.0589 us/op 0.96
OrderedSet add up to 64 items then delete middle 4.1455 us/op 4.3776 us/op 0.95
Set add up to 128 items then delete first 3.8991 us/op 3.9122 us/op 1.00
OrderedSet add up to 128 items then delete first 6.1404 us/op 5.8840 us/op 1.04
Set add up to 128 items then delete last 3.7853 us/op 3.8404 us/op 0.99
OrderedSet add up to 128 items then delete last 5.6988 us/op 6.0285 us/op 0.95
Set add up to 128 items then delete middle 3.7610 us/op 3.9063 us/op 0.96
OrderedSet add up to 128 items then delete middle 10.486 us/op 11.203 us/op 0.94
Set add up to 256 items then delete first 7.7329 us/op 7.7684 us/op 1.00
OrderedSet add up to 256 items then delete first 12.119 us/op 12.069 us/op 1.00
Set add up to 256 items then delete last 7.5123 us/op 7.9872 us/op 0.94
OrderedSet add up to 256 items then delete last 11.287 us/op 12.345 us/op 0.91
Set add up to 256 items then delete middle 7.5017 us/op 8.5795 us/op 0.87
OrderedSet add up to 256 items then delete middle 32.252 us/op 36.941 us/op 0.87
transfer serialized Status (84 B) 1.6410 us/op 1.6000 us/op 1.03
copy serialized Status (84 B) 1.4680 us/op 1.4860 us/op 0.99
transfer serialized SignedVoluntaryExit (112 B) 1.5290 us/op 1.5650 us/op 0.98
copy serialized SignedVoluntaryExit (112 B) 1.1790 us/op 1.4490 us/op 0.81
transfer serialized ProposerSlashing (416 B) 1.5470 us/op 1.7050 us/op 0.91
copy serialized ProposerSlashing (416 B) 1.4130 us/op 1.8910 us/op 0.75
transfer serialized Attestation (485 B) 1.5680 us/op 1.7550 us/op 0.89
copy serialized Attestation (485 B) 1.3620 us/op 1.7640 us/op 0.77
transfer serialized AttesterSlashing (33232 B) 1.6620 us/op 2.5380 us/op 0.65
copy serialized AttesterSlashing (33232 B) 3.3990 us/op 9.5780 us/op 0.35
transfer serialized Small SignedBeaconBlock (128000 B) 1.7050 us/op 2.6500 us/op 0.64
copy serialized Small SignedBeaconBlock (128000 B) 7.6430 us/op 26.984 us/op 0.28
transfer serialized Avg SignedBeaconBlock (200000 B) 1.8640 us/op 2.3470 us/op 0.79
copy serialized Avg SignedBeaconBlock (200000 B) 19.550 us/op 43.820 us/op 0.45
transfer serialized BlobsSidecar (524380 B) 2.7340 us/op 2.6410 us/op 1.04
copy serialized BlobsSidecar (524380 B) 82.510 us/op 116.32 us/op 0.71
transfer serialized Big SignedBeaconBlock (1000000 B) 2.9700 us/op 3.3100 us/op 0.90
copy serialized Big SignedBeaconBlock (1000000 B) 146.74 us/op 215.06 us/op 0.68
pass gossip attestations to forkchoice per slot 2.6480 ms/op 2.8380 ms/op 0.93
forkChoice updateHead vc 100000 bc 64 eq 0 540.26 us/op 482.34 us/op 1.12
forkChoice updateHead vc 600000 bc 64 eq 0 2.6567 ms/op 3.0077 ms/op 0.88
forkChoice updateHead vc 1000000 bc 64 eq 0 4.5145 ms/op 4.5432 ms/op 0.99
forkChoice updateHead vc 600000 bc 320 eq 0 2.6550 ms/op 2.6454 ms/op 1.00
forkChoice updateHead vc 600000 bc 1200 eq 0 2.8029 ms/op 2.7716 ms/op 1.01
forkChoice updateHead vc 600000 bc 7200 eq 0 3.7987 ms/op 3.4828 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 1000 9.5819 ms/op 10.373 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 10000 9.5265 ms/op 9.8645 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 11.820 ms/op 12.161 ms/op 0.97
computeDeltas 500000 validators 300 proto nodes 3.1128 ms/op 3.1184 ms/op 1.00
computeDeltas 500000 validators 1200 proto nodes 3.0752 ms/op 3.6818 ms/op 0.84
computeDeltas 500000 validators 7200 proto nodes 3.2246 ms/op 3.1981 ms/op 1.01
computeDeltas 750000 validators 300 proto nodes 4.5957 ms/op 4.9197 ms/op 0.93
computeDeltas 750000 validators 1200 proto nodes 5.0815 ms/op 4.8755 ms/op 1.04
computeDeltas 750000 validators 7200 proto nodes 4.9211 ms/op 5.0171 ms/op 0.98
computeDeltas 1400000 validators 300 proto nodes 9.4193 ms/op 10.282 ms/op 0.92
computeDeltas 1400000 validators 1200 proto nodes 9.7587 ms/op 10.768 ms/op 0.91
computeDeltas 1400000 validators 7200 proto nodes 10.040 ms/op 9.7215 ms/op 1.03
computeDeltas 2100000 validators 300 proto nodes 14.949 ms/op 14.249 ms/op 1.05
computeDeltas 2100000 validators 1200 proto nodes 14.615 ms/op 15.160 ms/op 0.96
computeDeltas 2100000 validators 7200 proto nodes 15.124 ms/op 14.818 ms/op 1.02
computeProposerBoostScoreFromBalances 500000 validators 2.8981 ms/op 2.8930 ms/op 1.00
computeProposerBoostScoreFromBalances 750000 validators 2.8499 ms/op 2.8920 ms/op 0.99
computeProposerBoostScoreFromBalances 1400000 validators 2.8083 ms/op 2.9361 ms/op 0.96
computeProposerBoostScoreFromBalances 2100000 validators 2.8177 ms/op 2.9915 ms/op 0.94
altair processAttestation - 250000 vs - 7PWei normalcase 2.7255 ms/op 12.783 ms/op 0.21
altair processAttestation - 250000 vs - 7PWei worstcase 2.3829 ms/op 12.375 ms/op 0.19
altair processAttestation - setStatus - 1/6 committees join 82.918 us/op 183.88 us/op 0.45
altair processAttestation - setStatus - 1/3 committees join 181.15 us/op 257.85 us/op 0.70
altair processAttestation - setStatus - 1/2 committees join 230.77 us/op 311.88 us/op 0.74
altair processAttestation - setStatus - 2/3 committees join 324.28 us/op 331.71 us/op 0.98
altair processAttestation - setStatus - 4/5 committees join 434.00 us/op 554.74 us/op 0.78
altair processAttestation - setStatus - 100% committees join 537.32 us/op 588.18 us/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase 9.2222 ms/op 10.266 ms/op 0.90
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.489 ms/op 41.150 ms/op 0.69
altair processBlock - 250000 vs - 7PWei worstcase 37.888 ms/op 42.412 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase hashState 87.582 ms/op 108.59 ms/op 0.81
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8475 ms/op 2.2212 ms/op 1.28
phase0 processBlock - 250000 vs - 7PWei worstcase 28.630 ms/op 26.671 ms/op 1.07
altair processEth1Data - 250000 vs - 7PWei normalcase 297.02 us/op 460.20 us/op 0.65
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.808 us/op 14.303 us/op 0.83
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 58.208 us/op 51.789 us/op 1.12
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 19.744 us/op 17.643 us/op 1.12
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.931 us/op 15.948 us/op 0.69
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 231.76 us/op 173.35 us/op 1.34
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.3540 ms/op 1.0752 ms/op 1.26
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6183 ms/op 1.6037 ms/op 1.01
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 974.79 us/op 1.5285 ms/op 0.64
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.2459 ms/op 4.2723 ms/op 0.53
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.9297 ms/op 2.2487 ms/op 0.86
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.6778 ms/op 5.2732 ms/op 0.70
Tree 40 250000 create 291.08 ms/op 255.63 ms/op 1.14
Tree 40 250000 get(125000) 118.23 ns/op 134.44 ns/op 0.88
Tree 40 250000 set(125000) 763.28 ns/op 827.17 ns/op 0.92
Tree 40 250000 toArray() 20.549 ms/op 29.768 ms/op 0.69
Tree 40 250000 iterate all - toArray() + loop 20.834 ms/op 23.184 ms/op 0.90
Tree 40 250000 iterate all - get(i) 49.718 ms/op 60.034 ms/op 0.83
MutableVector 250000 create 13.804 ms/op 12.053 ms/op 1.15
MutableVector 250000 get(125000) 7.5370 ns/op 6.2240 ns/op 1.21
MutableVector 250000 set(125000) 221.87 ns/op 223.38 ns/op 0.99
MutableVector 250000 toArray() 3.4472 ms/op 2.7597 ms/op 1.25
MutableVector 250000 iterate all - toArray() + loop 3.5251 ms/op 4.7855 ms/op 0.74
MutableVector 250000 iterate all - get(i) 1.3470 ms/op 1.4304 ms/op 0.94
Array 250000 create 3.6313 ms/op 4.5071 ms/op 0.81
Array 250000 clone - spread 1.1377 ms/op 1.1982 ms/op 0.95
Array 250000 get(125000) 0.60800 ns/op 0.62000 ns/op 0.98
Array 250000 set(125000) 0.69900 ns/op 0.70800 ns/op 0.99
Array 250000 iterate all - loop 78.239 us/op 87.632 us/op 0.89
effectiveBalanceIncrements clone Uint8Array 300000 28.347 us/op 15.118 us/op 1.88
effectiveBalanceIncrements clone MutableVector 300000 407.00 ns/op 323.00 ns/op 1.26
effectiveBalanceIncrements rw all Uint8Array 300000 168.74 us/op 173.16 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 66.064 ms/op 78.842 ms/op 0.84
phase0 afterProcessEpoch - 250000 vs - 7PWei 77.896 ms/op 84.293 ms/op 0.92
phase0 beforeProcessEpoch - 250000 vs - 7PWei 44.279 ms/op 57.570 ms/op 0.77
altair processEpoch - mainnet_e81889 440.31 ms/op 485.79 ms/op 0.91
mainnet_e81889 - altair beforeProcessEpoch 65.046 ms/op 78.445 ms/op 0.83
mainnet_e81889 - altair processJustificationAndFinalization 10.142 us/op 17.079 us/op 0.59
mainnet_e81889 - altair processInactivityUpdates 7.1620 ms/op 7.7604 ms/op 0.92
mainnet_e81889 - altair processRewardsAndPenalties 52.753 ms/op 70.059 ms/op 0.75
mainnet_e81889 - altair processRegistryUpdates 1.9340 us/op 3.6380 us/op 0.53
mainnet_e81889 - altair processSlashings 695.00 ns/op 721.00 ns/op 0.96
mainnet_e81889 - altair processEth1DataReset 623.00 ns/op 425.00 ns/op 1.47
mainnet_e81889 - altair processEffectiveBalanceUpdates 935.25 us/op 917.58 us/op 1.02
mainnet_e81889 - altair processSlashingsReset 2.3410 us/op 3.8820 us/op 0.60
mainnet_e81889 - altair processRandaoMixesReset 3.3750 us/op 3.2060 us/op 1.05
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2630 us/op 3.1760 us/op 0.40
mainnet_e81889 - altair processParticipationFlagUpdates 1.9200 us/op 1.6170 us/op 1.19
mainnet_e81889 - altair processSyncCommitteeUpdates 518.00 ns/op 742.00 ns/op 0.70
mainnet_e81889 - altair afterProcessEpoch 80.489 ms/op 84.995 ms/op 0.95
capella processEpoch - mainnet_e217614 1.9049 s/op 2.1211 s/op 0.90
mainnet_e217614 - capella beforeProcessEpoch 406.92 ms/op 453.19 ms/op 0.90
mainnet_e217614 - capella processJustificationAndFinalization 9.1480 us/op 9.7790 us/op 0.94
mainnet_e217614 - capella processInactivityUpdates 19.349 ms/op 16.188 ms/op 1.20
mainnet_e217614 - capella processRewardsAndPenalties 473.22 ms/op 493.92 ms/op 0.96
mainnet_e217614 - capella processRegistryUpdates 29.745 us/op 19.639 us/op 1.51
mainnet_e217614 - capella processSlashings 549.00 ns/op 450.00 ns/op 1.22
mainnet_e217614 - capella processEth1DataReset 524.00 ns/op 448.00 ns/op 1.17
mainnet_e217614 - capella processEffectiveBalanceUpdates 2.9661 ms/op 3.1101 ms/op 0.95
mainnet_e217614 - capella processSlashingsReset 2.5420 us/op 2.6880 us/op 0.95
mainnet_e217614 - capella processRandaoMixesReset 4.9220 us/op 3.6100 us/op 1.36
mainnet_e217614 - capella processHistoricalRootsUpdate 984.00 ns/op 693.00 ns/op 1.42
mainnet_e217614 - capella processParticipationFlagUpdates 1.5570 us/op 1.4090 us/op 1.11
mainnet_e217614 - capella afterProcessEpoch 224.52 ms/op 212.77 ms/op 1.06
phase0 processEpoch - mainnet_e58758 422.76 ms/op 358.76 ms/op 1.18
mainnet_e58758 - phase0 beforeProcessEpoch 125.51 ms/op 119.34 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 13.774 us/op 10.832 us/op 1.27
mainnet_e58758 - phase0 processRewardsAndPenalties 58.052 ms/op 46.233 ms/op 1.26
mainnet_e58758 - phase0 processRegistryUpdates 8.9800 us/op 10.054 us/op 0.89
mainnet_e58758 - phase0 processSlashings 653.00 ns/op 425.00 ns/op 1.54
mainnet_e58758 - phase0 processEth1DataReset 562.00 ns/op 701.00 ns/op 0.80
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 746.08 us/op 852.30 us/op 0.88
mainnet_e58758 - phase0 processSlashingsReset 2.2460 us/op 2.4420 us/op 0.92
mainnet_e58758 - phase0 processRandaoMixesReset 3.8210 us/op 3.2960 us/op 1.16
mainnet_e58758 - phase0 processHistoricalRootsUpdate 598.00 ns/op 545.00 ns/op 1.10
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.5760 us/op 2.7710 us/op 1.65
mainnet_e58758 - phase0 afterProcessEpoch 66.296 ms/op 68.760 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 939.56 us/op 916.09 us/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5834 ms/op 1.1756 ms/op 1.35
altair processInactivityUpdates - 250000 normalcase 16.280 ms/op 25.158 ms/op 0.65
altair processInactivityUpdates - 250000 worstcase 17.721 ms/op 25.755 ms/op 0.69
phase0 processRegistryUpdates - 250000 normalcase 7.8220 us/op 7.2610 us/op 1.08
phase0 processRegistryUpdates - 250000 badcase_full_deposits 411.15 us/op 366.88 us/op 1.12
phase0 processRegistryUpdates - 250000 worstcase 0.5 107.79 ms/op 135.87 ms/op 0.79
altair processRewardsAndPenalties - 250000 normalcase 63.722 ms/op 64.376 ms/op 0.99
altair processRewardsAndPenalties - 250000 worstcase 61.406 ms/op 63.129 ms/op 0.97
phase0 getAttestationDeltas - 250000 normalcase 5.4687 ms/op 8.3145 ms/op 0.66
phase0 getAttestationDeltas - 250000 worstcase 5.0842 ms/op 6.5628 ms/op 0.77
phase0 processSlashings - 250000 worstcase 1.6015 ms/op 1.8947 ms/op 0.85
altair processSyncCommitteeUpdates - 250000 101.23 ms/op 127.93 ms/op 0.79
BeaconState.hashTreeRoot - No change 354.00 ns/op 412.00 ns/op 0.86
BeaconState.hashTreeRoot - 1 full validator 141.18 us/op 133.50 us/op 1.06
BeaconState.hashTreeRoot - 32 full validator 1.2179 ms/op 1.3245 ms/op 0.92
BeaconState.hashTreeRoot - 512 full validator 13.565 ms/op 14.045 ms/op 0.97
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 131.38 us/op 133.66 us/op 0.98
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.7044 ms/op 1.7377 ms/op 0.98
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 21.382 ms/op 30.651 ms/op 0.70
BeaconState.hashTreeRoot - 1 balances 133.99 us/op 143.04 us/op 0.94
BeaconState.hashTreeRoot - 32 balances 979.01 us/op 1.4212 ms/op 0.69
BeaconState.hashTreeRoot - 512 balances 12.366 ms/op 13.109 ms/op 0.94
BeaconState.hashTreeRoot - 250000 balances 189.34 ms/op 178.21 ms/op 1.06
aggregationBits - 2048 els - zipIndexesInBitList 12.949 us/op 11.055 us/op 1.17
byteArrayEquals 32 47.016 ns/op 48.711 ns/op 0.97
Buffer.compare 32 39.751 ns/op 40.559 ns/op 0.98
byteArrayEquals 1024 1.2591 us/op 1.2788 us/op 0.98
Buffer.compare 1024 46.837 ns/op 46.867 ns/op 1.00
byteArrayEquals 16384 20.448 us/op 22.207 us/op 0.92
Buffer.compare 16384 206.40 ns/op 236.94 ns/op 0.87
byteArrayEquals 123687377 150.33 ms/op 171.94 ms/op 0.87
Buffer.compare 123687377 4.8260 ms/op 6.9089 ms/op 0.70
byteArrayEquals 32 - diff last byte 52.487 ns/op 50.924 ns/op 1.03
Buffer.compare 32 - diff last byte 39.519 ns/op 40.630 ns/op 0.97
byteArrayEquals 1024 - diff last byte 1.3118 us/op 1.2843 us/op 1.02
Buffer.compare 1024 - diff last byte 51.361 ns/op 47.859 ns/op 1.07
byteArrayEquals 16384 - diff last byte 20.649 us/op 20.828 us/op 0.99
Buffer.compare 16384 - diff last byte 239.17 ns/op 220.40 ns/op 1.09
byteArrayEquals 123687377 - diff last byte 163.52 ms/op 169.33 ms/op 0.97
Buffer.compare 123687377 - diff last byte 7.2148 ms/op 6.8393 ms/op 1.05
byteArrayEquals 32 - random bytes 6.8950 ns/op 6.1680 ns/op 1.12
Buffer.compare 32 - random bytes 42.361 ns/op 43.077 ns/op 0.98
byteArrayEquals 1024 - random bytes 6.0270 ns/op 6.3120 ns/op 0.95
Buffer.compare 1024 - random bytes 40.198 ns/op 44.249 ns/op 0.91
byteArrayEquals 16384 - random bytes 5.9700 ns/op 5.3340 ns/op 1.12
Buffer.compare 16384 - random bytes 39.081 ns/op 42.837 ns/op 0.91
byteArrayEquals 123687377 - random bytes 17.380 ns/op 8.7700 ns/op 1.98
Buffer.compare 123687377 - random bytes 50.710 ns/op 51.620 ns/op 0.98
regular array get 100000 times 34.744 us/op 35.163 us/op 0.99
wrappedArray get 100000 times 34.132 us/op 34.619 us/op 0.99
arrayWithProxy get 100000 times 11.717 ms/op 11.983 ms/op 0.98
ssz.Root.equals 55.741 ns/op 58.662 ns/op 0.95
byteArrayEquals 54.364 ns/op 51.544 ns/op 1.05
Buffer.compare 13.309 ns/op 11.540 ns/op 1.15
shuffle list - 16384 els 4.9014 ms/op 6.4268 ms/op 0.76
shuffle list - 250000 els 75.154 ms/op 81.649 ms/op 0.92
processSlot - 1 slots 16.358 us/op 19.786 us/op 0.83
processSlot - 32 slots 4.0057 ms/op 4.4019 ms/op 0.91
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 51.035 ms/op 55.741 ms/op 0.92
getCommitteeAssignments - req 1 vs - 250000 vc 2.3188 ms/op 2.3509 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 3.5386 ms/op 3.5083 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 3.9362 ms/op 3.9272 ms/op 1.00
findModifiedValidators - 10000 modified validators 489.04 ms/op 540.02 ms/op 0.91
findModifiedValidators - 1000 modified validators 364.75 ms/op 423.95 ms/op 0.86
findModifiedValidators - 100 modified validators 360.37 ms/op 394.36 ms/op 0.91
findModifiedValidators - 10 modified validators 313.18 ms/op 359.61 ms/op 0.87
findModifiedValidators - 1 modified validators 331.72 ms/op 356.77 ms/op 0.93
findModifiedValidators - no difference 303.66 ms/op 390.77 ms/op 0.78
compare ViewDUs 4.6232 s/op 4.9290 s/op 0.94
compare each validator Uint8Array 1.5880 s/op 1.6847 s/op 0.94
compare ViewDU to Uint8Array 1.1097 s/op 927.24 ms/op 1.20
migrate state 1000000 validators, 24 modified, 0 new 677.46 ms/op 693.89 ms/op 0.98
migrate state 1000000 validators, 1700 modified, 1000 new 946.43 ms/op 967.31 ms/op 0.98
migrate state 1000000 validators, 3400 modified, 2000 new 1.3695 s/op 1.1512 s/op 1.19
migrate state 1500000 validators, 24 modified, 0 new 769.58 ms/op 589.89 ms/op 1.30
migrate state 1500000 validators, 1700 modified, 1000 new 916.19 ms/op 963.19 ms/op 0.95
migrate state 1500000 validators, 3400 modified, 2000 new 1.1386 s/op 1.1352 s/op 1.00
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6600 ns/op 4.9500 ns/op 0.94
state getBlockRootAtSlot - 250000 vs - 7PWei 641.35 ns/op 450.26 ns/op 1.42
computeProposers - vc 250000 5.7146 ms/op 5.9652 ms/op 0.96
computeEpochShuffling - vc 250000 71.335 ms/op 69.558 ms/op 1.03
getNextSyncCommittee - vc 250000 99.367 ms/op 106.02 ms/op 0.94
computeSigningRoot for AttestationData 19.933 us/op 22.746 us/op 0.88
hash AttestationData serialized data then Buffer.toString(base64) 1.3042 us/op 1.2459 us/op 1.05
toHexString serialized data 823.59 ns/op 811.17 ns/op 1.02
Buffer.toString(base64) 158.38 ns/op 153.34 ns/op 1.03

by benchmarkbot/action

@nflaig nflaig mentioned this pull request Nov 3, 2023
Closed
@g11tech g11tech enabled auto-merge (squash) November 3, 2023 13:06
@g11tech g11tech merged commit a311a8b into unstable Nov 3, 2023
20 checks passed
@g11tech g11tech deleted the g11tech/builder-alias branch November 3, 2023 13:25
philknows pushed a commit that referenced this pull request Nov 7, 2023
@g11tech @nflaig @philknows
refactor: repurpose --builder flag to alias maxprofit builder.selecti…
e47e63a 
…on and turn builder off by default (#6081)

* refac: repurpose --builder flag to alias maxprofit builder.selection and turn builder off by default

* log init options for validator

* Update packages/cli/src/cmds/validator/options.ts

Co-authored-by: Nico Flaig <[email protected]>

---------

Co-authored-by: Nico Flaig <[email protected]>
@philknows philknows mentioned this pull request Nov 8, 2023
Merged
15 tasks
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @wemeetagain @nflaig