-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to docusaurus #6533
Migrate to docusaurus #6533
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6533 +/- ##
============================================
- Coverage 61.53% 61.39% -0.14%
============================================
Files 556 556
Lines 58647 58751 +104
Branches 1847 1848 +1
============================================
- Hits 36087 36073 -14
- Misses 22520 22638 +118
Partials 40 40 |
We definitely need a detailed visual review of the new docs vs. our current docs, just quickly skimming through
|
@@ -198,7 +202,7 @@ function renderSubCommand(sub: SubCommandDefinition, lodestarCommand?: string): | |||
renderOptions( | |||
sub.options, | |||
`### \`${sub.command}\` Options`, | |||
"_Supports all parent command options plus the following:_\n\n<br>" | |||
"_Supports all parent command options plus the following:_\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"_Supports all parent command options plus the following:_\n\n" | |
`_Supports all parent command options plus the following:_${LINE_BREAK}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a docusaurus thing? Couldn't find mention of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That was a remnant from updating the script to build the cli docs. In some places the line separator needed the extra <br />
but in other it did not to look correct. As long as it no longer a thing we can just use the single LINE_BREAK const.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job overall!! Just a few things I noticed but great work!
Just as a note I did not visually check all the pages, I only reviewed the github diff and started things up to make sure all worked on my box as well (WOMM works on my machine lol). There was a lot here so we may need another bite at the apple.
But again, great addition to the codebase!! 🚀
I also very much agree with this!!! I saw some options for generating a minimap so should be possible |
I think this would be a good idea if we can implement this. |
I think overall this is a good start, with this PR focusing on the migration itself, we should aim to get this setup with the top level settings we want and the high level structure of our docs. We can then do follow up PRs also which can go further into the contents of the docs such as rearranging and cleaning up context. |
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: Phil Ngo <[email protected]>
Co-authored-by: Phil Ngo <[email protected]>
The footer is the regular Regarding versioning, I plan to address that in a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Talked with @jeluard in DM and a couple of the clean-up things will be handled in separate PR. You rock dude!! Good job! 🎸
🎉 This PR is included in v1.18.0 🎉 |
Motivation
Migrate documentation to docusaurus. Test the deployment here
Relates to #6517