-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token-file as an alias to configure keymanager token file #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
force-pushed
the
nflaig/token-file-alias
branch
from
March 28, 2024 13:15
1635519
to
6c53a2b
Compare
nflaig
changed the title
chore: add token-file as an alias to configure keymanager token file
feat: add token-file as an alias to configure keymanager token file
Mar 28, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6609 +/- ##
=========================================
Coverage 61.61% 61.61%
=========================================
Files 556 556
Lines 58567 58567
Branches 1859 1859
=========================================
Hits 36084 36084
Misses 22442 22442
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
approved these changes
Apr 3, 2024
🎉 This PR is included in v1.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up to #6525 which adds an alias that matches the spec value ethereum/keymanager-APIs#74.
Description
Adds
--tokenFile
/--token-file
as an alias to configure keymanager token file.Note: yargs automatically supports both camel case and kebab (hyphen) case
Steps to test or reproduce