-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track leaked libp2p connections #6656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6656 +/- ##
============================================
- Coverage 61.69% 61.68% -0.01%
============================================
Files 556 556
Lines 58820 58825 +5
Branches 1887 1887
============================================
Hits 36287 36287
- Misses 22492 22497 +5
Partials 41 41 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nflaig
reviewed
Apr 10, 2024
nflaig
approved these changes
Apr 10, 2024
nflaig
added a commit
that referenced
this pull request
Apr 11, 2024
* feat: track leaked libp2p connections * update var name --------- Co-authored-by: Nico Flaig <[email protected]>
🎉 This PR is included in v1.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lodestar periodically prune leaked connections if our peer data is > 2x actual connections, and we don't track it while in the profile shown here there are > 15k of leaked connections
Description
lodestar_peer_manager_leaked_connections_count
metricpart of #6595
Steps to test or reproduce