Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attestation pool for electra #6744

Merged
merged 4 commits into from
May 8, 2024
Merged

fix: attestation pool for electra #6744

merged 4 commits into from
May 8, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented May 8, 2024

Motivation

Fix attestation pool for electra

Description

  • similar to aggregated pool, attestation pool need group by data root first, then by committee index for electra
  • escalate the change to api and validator
  • address some comments in feat: implement EIP-7549 #6689
  • add and use assert.notNull() util

cc @ensi321

@twoeths twoeths marked this pull request as ready for review May 8, 2024 03:48
@twoeths twoeths requested a review from a team as a code owner May 8, 2024 03:48
@twoeths twoeths mentioned this pull request May 8, 2024
Merged
Base automatically changed from nc/7549 to electra-fork May 8, 2024 11:00
@g11tech g11tech force-pushed the tuyen/EIP_7549_attestationPool branch from 5a722d7 to 93e84eb Compare May 8, 2024 11:07
g11tech
g11tech approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech merged commit 59f3abe into electra-fork May 8, 2024
6 checks passed
@g11tech g11tech deleted the tuyen/EIP_7549_attestationPool branch May 8, 2024 11:09
g11tech pushed a commit that referenced this pull request May 24, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
d5214c0 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
@twoeths @g11tech
fix: attestation pool for electra (ChainSafe#6744)
1705888 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Jun 25, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
60fc855 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Jun 25, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
aaca7a7 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Jul 1, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
1d74606 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Jul 30, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
359ecc5 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Jul 31, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
57d89bb 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Aug 2, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
db5c515 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Aug 9, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
3a94aa5 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Aug 9, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
dc6aaee 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Aug 23, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
974edd2 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
g11tech pushed a commit that referenced this pull request Aug 27, 2024
@twoeths @g11tech
fix: attestation pool for electra (#6744)
09e7510 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
philknows pushed a commit that referenced this pull request Sep 3, 2024
@twoeths @philknows
fix: attestation pool for electra (#6744)
e1f5ddf 
* feat: attestationPool to group by slot by data root by committee index for electra

* fix: gossip validation and assert.notNull() util

* fix: remove light-client stats.html

* fix: lint and check-types
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @g11tech