test(spec): fix attestors slashing specs for electra fork #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
reviewed
May 10, 2024
| @@ -52,7 +52,7 @@ export function computeExitEpochAndUpdateChurn(state: CachedBeaconStateElectra, | |||
| // Exit doesn't fit in the current earliest epoch. | |||
| if (exitBalance > exitBalanceToConsume) { | |||
| const balanceToProcess = Number(exitBalance) - exitBalanceToConsume; | |||
| const additionalEpochs = Math.floor((balanceToProcess - 1) / (perEpochChurn + 1)); | |||
| const additionalEpochs = Math.ceil((balanceToProcess - 1) / (perEpochChurn + 1)); | |||
There was a problem hiding this comment.
Could you detail this? Also, is it worth having some test for this, as apparently this change didn't require any associated test change.
There was a problem hiding this comment.
Ideally my preferences is to have unit tests for every function, but unfortunatley we don't have it yet.
I updated with a code comment.
There was a problem hiding this comment.
Oh! I misread the spec here.
We should do
const additionalEpochs = Math.floor((balanceToProcess - 1) / perEpochChurn) + 1
Let me know if the spec test's still passing after making this change
packages/state-transition/src/block/isValidIndexedAttestation.ts
Outdated
Show resolved
Hide resolved
ensi321
reviewed
May 10, 2024
packages/state-transition/src/block/isValidIndexedAttestation.ts
Outdated
Show resolved
Hide resolved
| @@ -52,7 +52,7 @@ export function computeExitEpochAndUpdateChurn(state: CachedBeaconStateElectra, | |||
| // Exit doesn't fit in the current earliest epoch. | |||
| if (exitBalance > exitBalanceToConsume) { | |||
| const balanceToProcess = Number(exitBalance) - exitBalanceToConsume; | |||
| const additionalEpochs = Math.floor((balanceToProcess - 1) / (perEpochChurn + 1)); | |||
| const additionalEpochs = Math.ceil((balanceToProcess - 1) / (perEpochChurn + 1)); | |||
There was a problem hiding this comment.
Oh! I misread the spec here.
We should do
const additionalEpochs = Math.floor((balanceToProcess - 1) / perEpochChurn) + 1
Let me know if the spec test's still passing after making this change
Yes both expressions have same impact. Either to use |
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
…6758) * Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Fix attester slashing specs for electra * Remove unused import * Add code comment * Update the expression * Update the fork check
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the spec coverage for electra fork
Description
Fix attestor slashing for the elctra-fork.
Steps to test or reproduce