fix: inline sourcemaps to help with debugging #6768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
approved these changes
May 14, 2024
wemeetagain
approved these changes
May 14, 2024
| @@ -40,6 +40,7 @@ export function getBaseViteConfig( | |||
| esbuild: { | |||
| banner, | |||
| legalComments: "none", | |||
| sourcemap: "inline", | |||
There was a problem hiding this comment.
The vite file is not for the vitest, rather it's for the bundle packages. I am surprised changing any of this effects debugging. If you actually need sourcemaps for the tests then use this option https://vitest.dev/config/#server-sourcemap
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Turns on inline sourcemaps to help with debugging under vitest. Only works with vscode enabled debugging console and will work to get this expended to a debug launch profile