Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: electra fork transition spec tests #6769

Merged
merged 3 commits into from
May 14, 2024
Merged

fix: electra fork transition spec tests #6769

merged 3 commits into from
May 14, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented May 14, 2024

Motivation

Fix electra fork transition spec tests

Description

Follow https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/fork.md

· deneb/fork/fork/pyspec_tests/deneb_fork_random_2
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_2
 ✓ test/spec/presets/fork.test.ts (72) 1554ms
   ✓ altair/fork/fork/pyspec_tests (16) 475ms
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_0
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_1
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_2
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_3
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_duplicate_attestations
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_large_validator_set
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_low_balances
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_misc_balances
     ✓ altair/fork/fork/pyspec_tests/altair_fork_random_mismatched_attestations
     ✓ altair/fork/fork/pyspec_tests/fork_base_state
     ✓ altair/fork/fork/pyspec_tests/fork_many_next_epoch
     ✓ altair/fork/fork/pyspec_tests/fork_next_epoch
     ✓ altair/fork/fork/pyspec_tests/fork_next_epoch_with_block
     ✓ altair/fork/fork/pyspec_tests/fork_random_large_validator_set
     ✓ altair/fork/fork/pyspec_tests/fork_random_low_balances
     ✓ altair/fork/fork/pyspec_tests/fork_random_misc_balances
   ✓ bellatrix/fork/fork/pyspec_tests (14)
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_0
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_1
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_2
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_3
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_large_validator_set
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_low_balances
     ✓ bellatrix/fork/fork/pyspec_tests/bellatrix_fork_random_misc_balances
     ✓ bellatrix/fork/fork/pyspec_tests/fork_base_state
     ✓ bellatrix/fork/fork/pyspec_tests/fork_many_next_epoch
     ✓ bellatrix/fork/fork/pyspec_tests/fork_next_epoch
     ✓ bellatrix/fork/fork/pyspec_tests/fork_next_epoch_with_block
     ✓ bellatrix/fork/fork/pyspec_tests/fork_random_large_validator_set
     ✓ bellatrix/fork/fork/pyspec_tests/fork_random_low_balances
     ✓ bellatrix/fork/fork/pyspec_tests/fork_random_misc_balances
   ✓ capella/fork/fork/pyspec_tests (14)
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_0
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_1
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_2
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_3
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_large_validator_set
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_low_balances
     ✓ capella/fork/fork/pyspec_tests/capella_fork_random_misc_balances
     ✓ capella/fork/fork/pyspec_tests/fork_base_state
     ✓ capella/fork/fork/pyspec_tests/fork_many_next_epoch
     ✓ capella/fork/fork/pyspec_tests/fork_next_epoch
     ✓ capella/fork/fork/pyspec_tests/fork_next_epoch_with_block
     ✓ capella/fork/fork/pyspec_tests/fork_random_large_validator_set
     ✓ capella/fork/fork/pyspec_tests/fork_random_low_balances
     ✓ capella/fork/fork/pyspec_tests/fork_random_misc_balances
   ✓ deneb/fork/fork/pyspec_tests (14) 381ms
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_0
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_1
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_2
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_3
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_large_validator_set
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_low_balances
     ✓ deneb/fork/fork/pyspec_tests/deneb_fork_random_misc_balances
     ✓ deneb/fork/fork/pyspec_tests/fork_base_state
     ✓ deneb/fork/fork/pyspec_tests/fork_many_next_epoch
     ✓ deneb/fork/fork/pyspec_tests/fork_next_epoch
     ✓ deneb/fork/fork/pyspec_tests/fork_next_epoch_with_block
     ✓ deneb/fork/fork/pyspec_tests/fork_random_large_validator_set
     ✓ deneb/fork/fork/pyspec_tests/fork_random_low_balances
     ✓ deneb/fork/fork/pyspec_tests/fork_random_misc_balances
   ✓ electra/fork/fork/pyspec_tests (14)
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_0
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_1
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_2
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_3
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_large_validator_set
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_low_balances
     ✓ electra/fork/fork/pyspec_tests/electra_fork_random_misc_balances
     ✓ electra/fork/fork/pyspec_tests/fork_base_state
     ✓ electra/fork/fork/pyspec_tests/fork_many_next_epoch
     ✓ electra/fork/fork/pyspec_tests/fork_next_epoch
     ✓ electra/fork/fork/pyspec_tests/fork_next_epoch_with_block
     ✓ electra/fork/fork/pyspec_tests/fork_random_large_validator_set
     ✓ electra/fork/fork/pyspec_tests/fork_random_low_balances
     ✓ electra/fork/fork/pyspec_tests/fork_random_misc_balances

 Test Files  1 passed (1)
      Tests  72 passed (72)

@twoeths twoeths requested a review from a team as a code owner May 14, 2024 09:21
@twoeths twoeths force-pushed the tuyen/fix_fork_spec_tests branch from 4e650ae to 31978f4 Compare May 14, 2024 09:26
wemeetagain
wemeetagain reviewed May 14, 2024
View reviewed changes
packages/state-transition/src/slot/upgradeStateToElectra.ts
exitEpochs.push(currentEpochPre);
}
stateElectraView.earliestExitEpoch = Math.max(...exitEpochs) + 1;
stateElectraView.consolidationBalanceToConsume = BigInt(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line needed if its set in L95?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line needed if its set in L95?

Current implementation of upgradeStateToElectra() is just a hacky function solely for devnet 0 and related spec tests.

Eventually we will need to replace upgradeStateToElectra() with upgradeStateToElectraOriginal(). I think we can clean up and fix small details at that time

@ensi321 ensi321 merged commit de9ed21 into electra-fork May 14, 2024
12 of 17 checks passed
@ensi321 ensi321 deleted the tuyen/fix_fork_spec_tests branch May 14, 2024 09:56
g11tech pushed a commit that referenced this pull request May 24, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
70a59b0 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (ChainSafe#6769)
4f99b2e 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Jun 25, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
d84c754 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Jun 25, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
005b639 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Jul 1, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
5c00644 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Jul 30, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
f90648c 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Jul 31, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
b6ce162 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Aug 2, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
3478ccd 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Aug 9, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
56289fd 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Aug 9, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
b008cf4 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Aug 23, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
0704e51 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
g11tech pushed a commit that referenced this pull request Aug 27, 2024
@twoeths @g11tech
fix: electra fork transition spec tests (#6769)
bd1bb6c 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
philknows pushed a commit that referenced this pull request Sep 3, 2024
@twoeths @philknows
fix: electra fork transition spec tests (#6769)
5bd564d 
* fix: electra fork transition

* fix: merge issue

* chore: remove unwanted change
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain left review comments

@ensi321 ensi321 ensi321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @ensi321