-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: effective balance cache is not in sync with validator effective balance #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
approved these changes
May 14, 2024
twoeths
approved these changes
May 14, 2024
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
…balance (ChainSafe#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
…balance (#6780) Update eb cache at fork transition
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
…balance (#6780) Update eb cache at fork transition
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
…balance (#6780) Update eb cache at fork transition
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During fork transition, the effective balance and balance of pending activation validators need to be zero out. But effective balance cache in EpochCache is not updated thus the discrepancy