-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: single state tree at start up #7056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7056 +/- ##
============================================
- Coverage 49.26% 49.24% -0.02%
============================================
Files 592 593 +1
Lines 39365 39447 +82
Branches 2251 2248 -3
============================================
+ Hits 19393 19427 +34
- Misses 19931 19979 +48
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
force-pushed
the
te/single_state_tree_at_start_up
branch
from
August 29, 2024 01:47
ba3cd96
to
bec9bfc
Compare
twoeths
force-pushed
the
te/single_state_tree_at_start_up
branch
from
September 6, 2024 01:34
bec9bfc
to
067f620
Compare
wemeetagain
approved these changes
Sep 9, 2024
philknows
pushed a commit
that referenced
this pull request
Sep 11, 2024
* feat: use db state to load ws state * feat: log state size * fix: rename initStateFromAnchorState to checkAndPersistAnchorState * fix: only persist anchor state if it's cp state * fix: avoid redundant anchor state serialization
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
hashTreeRoot()
call takes ~24s of blocking time at startupDescription
loadState()
api to load ws stateinitStateFromAnchorState
tocheckAndPersistAnchorState
and no return value, this is to reflect its implementationformatBytes()
util to log how many bytes we downloaded/loaded. Later on we should use the same api to track state diff PR feat: use binary diff to persist finalized states #7005Closes #7027
Test
after "Download completed" log, the beacon node can continue almost immediately instead of blocking for ~24s as currently #7027 (comment)