-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include more details in validator attestation logs #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
force-pushed
the
nflaig/attestation-logs
branch
from
August 30, 2024 08:23
a62c5a7
to
ef9a07a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7064 +/- ##
=========================================
Coverage 49.37% 49.37%
=========================================
Files 589 589
Lines 39233 39242 +9
Branches 2243 2249 +6
=========================================
+ Hits 19370 19377 +7
- Misses 19822 19823 +1
- Partials 41 42 +1 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Sep 2, 2024
ensi321
approved these changes
Sep 4, 2024
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would be nice to have a bit more details in vc attestation logs to know for which head the attestations voted and for aggregates, include the number of participants / signatures which is currently only tracked via metrics.
Description
Include more details in validator attestation logs