Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml: remove cached env if it appears invalid #7101

Closed
wants to merge 1 commit into from

Conversation

tripleee
Copy link
Member

Closes: #7100

@tripleee tripleee requested a review from makyen June 16, 2022 13:06
@makyen
Copy link
Contributor

makyen commented Jun 16, 2022

Unfortunately, I didn't see this while working on the same problem and running through test cycles in my fork. I like a combination of your solution, which only wipes the venv if the links are dead, and my solution, which retains the site_packages information for SD's dependencies while removing those which are dependent upon the Python minor version. However, your solution is safer, as it's possible for other packages to have a Python minor version dependency, or for new things to be added to the base Python virtual environment install. Overall, it's probably better to choose the safer version (i.e. yours).

@makyen
Copy link
Contributor

makyen commented Jun 16, 2022

After further testing, it looks like completely removing the venv from both GitHub Actions and CircleCI is a better way to go.

So, I'm going to close this.

@makyen makyen closed this Jun 16, 2022
@tripleee tripleee deleted the invalidate-cache-maybe branch June 17, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test failures in Github Actions for Python 3.10
2 participants