Updating 201 monitoring #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CharlyF Will you create a PR for upstream? I'd like to include this contribution. |
|
Will do @buzzsurfr , I noticed a few issues with the service meshes part as well, I'm trying to figure out what's going on. Edit: PR aws-samples#518 |
CharlyF
pushed a commit
that referenced
this pull request
Jul 9, 2018
Update readme.adoc - nodeds -> nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Also bumps ksm for more metrics and Prom-operator.
Description of changes:
Clarify the README.md for Cloud9 users. The user need to modify the proxy command to see the Grafana and Prometheus dashboards.
Also fixes the RBAC issue for the prometheus deployment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.