Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Interaction Localization support #78

Merged
merged 10 commits into from
Oct 16, 2022
Merged

Add Interaction Localization support #78

merged 10 commits into from
Oct 16, 2022

Conversation

OurTwinkie
Copy link

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the ______ module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

Describe your PR here.

Chew
Chew requested changes Oct 1, 2022
View reviewed changes
Copy link
Owner

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I'll need to do some testing then we'll be good to go.

I may want a helper to help make the locales, but we'll see.

command/src/main/java/com/jagrosh/jdautilities/command/SlashCommand.java Outdated Show resolved Hide resolved
command/src/main/java/com/jagrosh/jdautilities/command/SlashCommand.java Show resolved Hide resolved
command/src/main/java/com/jagrosh/jdautilities/command/SlashCommand.java Show resolved Hide resolved
command/src/main/java/com/jagrosh/jdautilities/command/SlashCommand.java Show resolved Hide resolved
@Chew Chew changed the title Adds the ability to change the localization of names and descriptions of slash commands depending on the language in discord. Add Slash Command Localization support Oct 1, 2022
@Chew
Copy link
Owner

Chew commented Oct 1, 2022

Do menus also have locales?

@OurTwinkie
Copy link
Author

Do menus also have locales?

No, today I will do the same for the menu and write the docs.

@Chew Chew changed the title Add Slash Command Localization support Add Interaction Localization support Oct 2, 2022
Chew
Chew approved these changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Gonna do some testing just to be sure.

@Chew Chew added enhancement New feature or request module: command Commands module labels Oct 2, 2022
@Chew
Copy link
Owner

Chew commented Oct 9, 2022 •
edited
Loading

image

Weird, I added the name localization to a parent command, but it didn't take effect for the child. Not sure what's up. Nor did description locale take effect.

@OurTwinkie
Copy link
Author

image

Weird, I added the name localization to a parent command, but it didn't take effect for the child. Not sure what's up. Nor did description locale take effect.

Fixed it, now it works.

@Chew
Copy link
Owner

Chew commented Oct 16, 2022

image

Looks great!

@Chew Chew merged commit 24f0614 into Chew:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chew Chew Chew approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request module: command Commands module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OurTwinkie @Chew