Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@jaraco @hoffmang9 Don't pass empty string to msvc linker. Ref pypa/setuptools#2417 #122

Merged
merged 3 commits into from
Nov 6, 2020
Merged

@jaraco @hoffmang9 Don't pass empty string to msvc linker. Ref pypa/setuptools#2417 #122

merged 3 commits into from
Nov 6, 2020

Conversation

hoffmang9
Copy link
Member

Also removed SETUPTOOLS_USE_DISTUTILS=stdlib from the Windows environment

@hoffmang9 hoffmang9 mentioned this pull request Nov 6, 2020
Closed
wjblanke
wjblanke approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah!

@hoffmang9 hoffmang9 merged commit b23557e into master Nov 6, 2020
@hoffmang9 hoffmang9 deleted the setuptools-win branch November 6, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoffmang9 @wjblanke @jaraco