Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the Debug Log harassment for linux users #52

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Chizaruu
Copy link
Owner

@Chizaruu Chizaruu commented Jun 5, 2023

This pull request addresses an issue related to debug logging in the codebase that specifically affects Linux users. The existing code snippet includes a catch block that throws a System.ComponentModel.Win32Exception when a command is not found or not accessible.

The updated code has modified the catch block to catch a general Exception instead. This change allows the code to continue executing in case of any exception, ensuring that Linux users are not bombarded with unnecessary debug log messages. A new debug log message has also been added to notify when a compatible dotnet command cannot be found.

These modifications enhance the code's compatibility with Linux systems and improve the user experience by reducing unnecessary debug log output.

@Chizaruu Chizaruu linked an issue Jun 5, 2023 that may be closed by this pull request
@Chizaruu
Copy link
Owner Author

Chizaruu commented Jun 5, 2023

@JooleanLogic feel free to test it out

Unity

  • Open Window/Package Manager
  • Click +
  • Select Add package from git URL
  • Paste https://github.com/Chizaruu/com.tsk.ide.vscode.git?path=/com.tsk.ide.vscode#51-unnecessary-getdotnetcommand-messages into URL
  • Click Add

@JooleanLogic
Copy link

Yep works a treat. No more harassment. :) Cheers mate.

@Chizaruu Chizaruu merged commit 25b7437 into default Jun 5, 2023
@Chizaruu Chizaruu deleted the 51-unnecessary-getdotnetcommand-messages branch June 5, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary GetDotnetCommand() Messages?
2 participants