Do not close the uploading page while uploading a video, without a warning message

[tio-trom]

If you upload a video and close the tab by mistake while uploading, that can be a disaster if you wait hours to upload. You should get a confirmation popup to close it.

Also, resumable uploads seem to not work. If I close the uploading window and then start to upload the same video again, it won't resume.

[kukhariev]

By default, file uploads should continue until the UploadxService is destroyed. But here, for some reason, it forces the complete removal of incomplete uploads from the server:

PeerTube/client/src/app/+videos/+video-edit/video-add-components/video-upload.component.ts

Lines 116 to 118 in 4d3e611

	ngOnDestroy () {
	this.cancelUpload()
	}

[tio-trom]

So is this a bug or? I don't understand....

By the way, using the 3.4.0 Peertube version. This https://videos.trom.tf/about/instance

[rigelk]

@kukhariev because we don't store enough information to recreate the upload component if it is destroyed by changing views.

So far, in what we implemented, resumable doesn't mean "close everything and come back to the same state", but just that unstable connections will eventually go through.

[tio-trom]

So is Peertube planning to add a more solid resumable-uploads feature? Would be very useful. At least show a warning to users when they close the page where an upload is happening. I think that's a must.

[ghost]

The original post was about a confirmation popup, no? I think that's for sure a good idea. The upload process right now is way too disrespectful of the user's time, really.

[kontrollanten]

A confirmation popup exists on the video edit/update page, I guess we can reuse that functionality.

[Chocobozzz]

Should be fixed by 221d876