fix: use requests and limits specified in envs / feat: specify priority #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the README.md mentions the feature of specifying CHECK_POD_CPU_REQUEST, CHECK_POD_CPU_LIMIT, CHECK_POD_MEM_REQUEST, CHECK_POD_MEM_LIMIT; it's not used while creating pods.
Due to this the default request and limits of the namespace are applied(These limits are pretty large as compared what is required for our jobs). We get a lot of false positives in which the job faces "OutOfCPU" error on a particular node.
Moreover, since this a critical check we should have a feature to specify the priority of the pods/jobs being created.