add timestamp to JUnit output format. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesFaucherre
force-pushed
the
CLI-ISSUE#1048
branch
2 times, most recently
from
0dc997b to
9aaa16b
Compare
JulesFaucherre
force-pushed
the
CLI-ISSUE#1048
branch
from
9aaa16b to
b4dabcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This change aims fixes the CLI issue #1048: the
timestampfield of the JUnit test resultConsiderations
In order to make tests predictable, an interface
Clockhas been added to mocktime.Now()in the tests.Changes
JUnitResultHandler.HandleResults, made sure every test suite filled itsTimestampfield withClock.Now()which, in non-test situation, equalstime.Now().