Early return instead of a nested if statement

CircleCI-Public · Jun 4, 2018 · 7443e59 · 7443e59
1 parent c6a1719
commit 7443e59
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -57,17 +57,17 @@ func init() {
 
 // TODO: move config stuff to it's own package
 func initConfig() {
-	if err := readConfig(); err != nil {
-		if err = createConfig(); err != nil {
-			fmt.Println(err.Error())
-			os.Exit(-1)
-		}
-		cfgFile = cfgPathDefault
-		fatalOnError(
-			"Failed to re-read config after creating a new file",
-			readConfig(), // reload config after creating it
-		)
+	if err := readConfig(); err == nil {
+		return
 	}
+
+	fatalOnError("Error creating a new config file", createConfig())
+
+	cfgFile = cfgPathDefault
+	fatalOnError(
+		"Failed to re-read config after creating a new file",
+		readConfig(), // reload config after creating it
+	)
 }
 
 func readConfig() (err error) {