Put segment key in the code

Moved the key inside the code because it was not possible not to add it to the Homebrew formula so we decided to write it in the code directly

Makefile

@@ -4,7 +4,7 @@ GOOS=$(shell go env GOOS)
 GOARCH=$(shell go env GOARCH)
 
 build: always
-	go build -o build/$(GOOS)/$(GOARCH)/circleci -ldflags="-X 'github.com/CircleCI-Public/circleci-cli/telemetry.SegmentEndpoint=' -X 'github.com/CircleCI-Public/circleci-cli/telemetry.SegmentKey="`echo ${SEGMENT_KEY}`"'"
+	go build -o build/$(GOOS)/$(GOARCH)/circleci -ldflags='-X github.com/CircleCI-Public/circleci-cli/telemetry.SegmentEndpoint='
 
 build-all: build/linux/amd64/circleci build/darwin/amd64/circleci
 

Taskfile.yml

@@ -49,7 +49,7 @@ tasks:
     cmds:
       # LDFlags sets the segment endpoint to an empty string thus letting the analytics library set the default endpoint on its own
       # Not setting the `SegmentEndpoint` variable would let the value in the code ie "http://localhost"
-      - go build -v -o build/$(go env GOOS)/$(go env GOARCH)/circleci -ldflags="-X 'github.com/CircleCI-Public/circleci-cli/telemetry.SegmentEndpoint=' -X 'github.com/CircleCI-Public/circleci-cli/telemetry.SegmentKey="`echo ${SEGMENT_KEY}`"'" .
+      - go build -v -o build/$(go env GOOS)/$(go env GOARCH)/circleci -ldflags='-X github.com/CircleCI-Public/circleci-cli/telemetry.SegmentEndpoint=' .
 
   build-linux:
     desc: Build main

cmd/create_telemetry.go

@@ -70,7 +70,7 @@ func CreateTelemetry(config *settings.Config) telemetry.Client {
 		return telemetry.CreateFileTelemetry(mockTelemetry)
 	}
 
-	if config.IsTelemetryDisabled {
+	if config.IsTelemetryDisabled || len(os.Getenv("CIRCLECI_CLI_TELEMETRY_OPTOUT")) != 0 {
 		return telemetry.CreateClient(telemetry.User{}, false)
 	}
 

cmd/root.go

@@ -194,7 +194,6 @@ func MakeCommands() *cobra.Command {
 	flags.StringVar(&rootOptions.Endpoint, "endpoint", rootOptions.Endpoint, "URI to your CircleCI GraphQL API endpoint")
 	flags.StringVar(&rootOptions.GitHubAPI, "github-api", "https://api.github.com/", "Change the default endpoint to GitHub API for retrieving updates")
 	flags.BoolVar(&rootOptions.SkipUpdateCheck, "skip-update-check", skipUpdateByDefault(), "Skip the check for updates check run before every command.")
-	flags.BoolVar(&rootOptions.IsTelemetryDisabled, "disable-telemetry", false, "Do not show telemetry for the actual command")
 	flags.StringVar(&rootOptions.MockTelemetry, "mock-telemetry", "", "The path where telemetry must be written")
 
 	hidden := []string{"github-api", "debug", "endpoint", "mock-telemetry"}

telemetry/telemetry.go

@@ -14,7 +14,7 @@ var (
 	CreateActiveTelemetry = newSegmentClient
 
 	SegmentEndpoint = "http://localhost"
-	SegmentKey      = ""
+	segmentKey      = "AbgkrgN4cbRhAVEwlzMkHbwvrXnxHh35"
 )
 
 type Approval string
@@ -91,7 +91,7 @@ type segmentClient struct {
 }
 
 func newSegmentClient(user User) Client {
-	cli, err := analytics.NewWithConfig(SegmentKey, analytics.Config{
+	cli, err := analytics.NewWithConfig(segmentKey, analytics.Config{
 		Endpoint: SegmentEndpoint,
 	})