Skip to content

Commit

Permalink
PIPE-4877 Remove config validate test with invalid org ID
Browse files Browse the repository at this point in the history
There has been a change to how configs are compiled that makes this test
invalid.

Previously we would allow any random owner ID to be passed in
when compiling certified orbs as these were enabled by default and
didn't require any checks with the provided owner ID.

To support an upcoming feature, now when compiling the config, all
provided owner IDs are checked and must exist to validate that the
organization allows that type of orb.

The CLI can continue to use no owner ID with public certified orbs as
tested in the above case.

https://github.com/CircleCI-Public/circleci-cli/blob/2766f0e710c8727e346e247f6c779079a79b010c/integration_tests/features/circleci_config.feature#L63-L85
  • Loading branch information
liamclarkedev committed Aug 22, 2024
1 parent 58be549 commit d0a1e4f
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions integration_tests/features/circleci_config.feature
Original file line number Diff line number Diff line change
Expand Up @@ -84,30 +84,6 @@ Feature: Config checking
Then the exit status should be 0
And the output should contain "Config file at config.yml is valid"

Scenario: Checking a valid config file with a private org
Given a file named "config.yml" with:
"""
version: 2.1
orbs:
node: circleci/[email protected]
jobs:
datadog-hello-world:
docker:
- image: cimg/base:stable
steps:
- run: |
echo "doing something really cool"
workflows:
datadog-hello-world:
jobs:
- datadog-hello-world
"""
When I run `circleci config validate --skip-update-check --org-id bb604b45-b6b0-4b81-ad80-796f15eddf87 -c config.yml`
Then the output should contain "Config file at config.yml is valid"
And the exit status should be 0

Scenario: Checking a valid config file with a non-existant orb
Given a file named "config.yml" with:
"""
Expand Down

0 comments on commit d0a1e4f

Please sign in to comment.