You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Love the idea! This should be simple to merge. I think the feature has a few more requirements:
I don't see where the global flag --http_timeout is setup? Did you do that part? Also, from the user's point of view, I don't think it matters that this is HTTP in the flag. Let's just call it --timeout and add the HTTP part to the inline help.
HTTP_TIMEOUT seems like too generic a term. Can we add a prefix to "namespace" the environment variable? CIRCLECI_CLI_TIMEOUT=30s should do fine.
There is another HTTP client in the CLI, used for exchanging with the GraphQL API (mostly for Orbs). Can we make sure the timeout is applied to both clients? (source)
Finally, I'd like to see at least one test in there. You can add an integration test to config/commands_test.go, creating a new mock server with httptest.NewServer that takes longer time to respond than the timeout.
Let me know if any of this is unclear, I'll be glad to help.
What problem does this feature solve?:
circleci config process / validate
commandscircleci
fails to execute due to timeout.Provide an example:
or
The text was updated successfully, but these errors were encountered: