Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default http client timeout override #1013

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

or-shachar
Copy link
Contributor

@or-shachar or-shachar commented Oct 26, 2023

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

export HTTP_TIMEOUT=30s
circleci config validate config.yml

Considerations

  • 10 seconds should definitely be enough for the API server to respond
  • This override feature is only for cases where there is some temporal misbehavior.

@or-shachar or-shachar requested a review from a team as a code owner October 26, 2023 12:34
@or-shachar
Copy link
Contributor Author

@loderunner - I've changed the name of the env variable to CIRCLECI_CLI_TIMEOUT - feel free to squash/merge + introduce a new PR with changes to the GQL client as well 🙏

@abdelDriowya
Copy link
Contributor

Thanks @or-shachar for your contribution, I will add timeout to graphql client and we will merge the pr after that

Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdelDriowya it would be great to add a little test on NewFromConfig to avoid regressions on this behaviour

@abdelDriowya abdelDriowya merged commit 43878aa into CircleCI-Public:develop Nov 7, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring http client timeout
3 participants