Release #1005
Merged
Release #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main -> dev
* Revert "revert: "feat: Put back telemetry" (#1001)" This reverts commit a516872. * fix: Fix runner token telemetry event * fix: Allow runner commands to run their PersistentPreRun With cobra, when you define a PersistentPreRun in a child command, you overwrite all the command's parents PersistentPreRun. When introducing telemetry, we used the PersistentPreRun to send the events, this made the runner commands not call the PersistentPreRun in cmd/runner/runner.go which defines the 'opts.r' value. In the commands the 'opts.r' was nil, thus causing nil pointer deference panic. This commit uses the PreRunE to send the telemetry event instead of the PersistentPreRun to avoid this issue.
atulsingh0
approved these changes
Sep 7, 2023
abdelDriowya
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.