Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improve error message #1019

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix/improve error message #1019

merged 1 commit into from
Nov 22, 2023

Conversation

JulesFaucherre
Copy link
Contributor

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

Reworded an error on circleci orb init. Fixing issue 1018.

Rationale

Compare the error with the go-git error to allow customised error.

Considerations

Screenshots

@JulesFaucherre JulesFaucherre requested review from a team as code owners November 22, 2023 13:16
@JulesFaucherre JulesFaucherre force-pushed the fix/improve-error-message branch from 6a4662f to 52edb96 Compare November 22, 2023 13:18
@JulesFaucherre JulesFaucherre merged commit 245d193 into develop Nov 22, 2023
1 check failed
@JulesFaucherre JulesFaucherre deleted the fix/improve-error-message branch November 22, 2023 13:18
@JulesFaucherre JulesFaucherre mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvincent42 jvincent42 jvincent42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulesFaucherre @jvincent42