Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs #1034

Merged
merged 5 commits into from
Jan 15, 2024
Merged

update docs #1034

merged 5 commits into from
Jan 15, 2024

Conversation

georgelivas
Copy link
Contributor

Update help command and docs for create command

@georgelivas georgelivas requested a review from a team as a code owner January 8, 2024 15:30
JulesFaucherre
JulesFaucherre suggested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little change on the example plus I believe you could take care of removing the vcs-type/org-name behaviour.
We can call if it's not clear.

cmd/namespace.go Outdated Show resolved Hide resolved
@georgelivas georgelivas force-pushed the DEVEX-1394/update-docs branch from 456e375 to edb27fd Compare January 8, 2024 15:58
@georgelivas georgelivas force-pushed the DEVEX-1394/update-docs branch 3 times, most recently from 8621805 to e97af42 Compare January 10, 2024 11:03
@georgelivas georgelivas force-pushed the DEVEX-1394/update-docs branch from e97af42 to 169d9e3 Compare January 11, 2024 10:51
JulesFaucherre
JulesFaucherre approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor remark but otherwise LGTM.

cmd/namespace.go Outdated Show resolved Hide resolved
@georgelivas georgelivas merged commit dcae517 into develop Jan 15, 2024
1 check passed
@georgelivas georgelivas deleted the DEVEX-1394/update-docs branch January 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesFaucherre JulesFaucherre JulesFaucherre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgelivas @JulesFaucherre