Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the context list table #1047

Merged
merged 1 commit into from
Mar 4, 2024
Merged

changed the context list table #1047

merged 1 commit into from
Mar 4, 2024

Conversation

JulesFaucherre
Copy link
Contributor

@JulesFaucherre JulesFaucherre commented Feb 28, 2024

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

  • Adding few product changes discussed in the ticket.

Rationale

N/A.

Considerations

N/A.

Screenshots

circleci context list

Before

Capture d’écran 2024-02-22 à 10 23 40

After

Capture d’écran 2024-02-28 à 16 55 09

circleci context list

Before

Capture d’écran 2024-02-22 à 10 38 21

After

Removed the slug from the message.
Capture d’écran 2024-02-28 à 16 56 43

@JulesFaucherre JulesFaucherre requested a review from a team as a code owner February 28, 2024 15:58
@jvincent42
Copy link
Contributor

What do you think of keeping the slug in the confirmation question ? Since we are using org-id now, it would be a nice indication that you are on the right organisation.

@JulesFaucherre
Copy link
Contributor Author

Yeah but it doesn't really make sense as for standalone you'd get circleci/<strange-id> one thing we can do is give the project name.

@jvincent42
Copy link
Contributor

Isn't it possible to get the organisation name ?

@JulesFaucherre
Copy link
Contributor Author

Oh sure, I meant the org name! Making the change.

@JulesFaucherre JulesFaucherre force-pushed the DEVEX-1216 branch 2 times, most recently from 581329c to 5c0915c Compare March 4, 2024 08:44
@JulesFaucherre
Copy link
Contributor Author

There is now the org name:
Capture d’écran 2024-03-04 à 09 46 49

@JulesFaucherre JulesFaucherre merged commit 1d5a050 into develop Mar 4, 2024
1 check passed
@JulesFaucherre JulesFaucherre deleted the DEVEX-1216 branch March 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants