PIPE-4359 Update config compilation pipeline values to add parameters #1052
+81
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
Rationale
=========
Config compilation now accepts pipeline values and parameters in a single map with the expected prefixes.
All standard values are now prefixed with
pipeline.
, and all parameters are prefixed withpipeline.parameters.
as described in the Pipeline Values documentation.https://circleci.com/docs/pipeline-variables/
Considerations
==============
The parameters inside pipeline values are not currently used, there are metrics in place to reach a 100% match before we start relying on the data in a single map.
Although the service is prepared to accept the new prefixed format, should things go wrong, this could impact any command that requires config compilation where the config references a pipeline value or parameter.