Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIFE-777] Update CODEOWNERS #1068

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[LIFE-777] Update CODEOWNERS #1068

merged 1 commit into from
Aug 20, 2024

Conversation

niubrandon
Copy link
Contributor

@niubrandon niubrandon commented Aug 20, 2024

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Update the codeowners from developer-experience to lifecycle

Rationale

=========

N/A

Considerations

==============

N/A

Screenshots

============

N/A

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@niubrandon niubrandon requested a review from a team as a code owner August 20, 2024 15:23
@niubrandon niubrandon merged commit 5b9241b into main Aug 20, 2024
1 check passed
@niubrandon niubrandon deleted the LIFE-777 branch August 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants