PIPE-4877 Remove config validate test with invalid org ID #1069
+0
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
Rationale
=========
There has been a change to how configs are compiled that makes this test invalid.
Previously we would allow any random owner ID to be passed in when compiling certified orbs as these were enabled by default and didn't require any checks with the provided owner ID.
To support an upcoming feature, now when compiling the config, all provided owner IDs are checked and must exist to validate that the organization allows that type of orb.
The CLI can continue to use no owner ID with public certified orbs as tested in the above case.
circleci-cli/integration_tests/features/circleci_config.feature
Lines 63 to 85 in 2766f0e
Considerations
==============
An alternative we can consider is to provide a valid private test organization ID to satisfy the test case, I opted against this since the config being compiled only uses a public certified orb which has the same behaviour with or without the owner ID.
Screenshots
============
Before
Image or [gif](https://giphy.com/apps/giphycapture)After
Image or gif where change can be clearly seenHere are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.