Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common code #12

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Refactor common code #12

merged 2 commits into from
Jul 4, 2018

Conversation

marcomorain
Copy link
Contributor

No description provided.

@marcomorain marcomorain force-pushed the refactor-common-code branch 3 times, most recently from 1a72430 to b558ce3 Compare July 2, 2018 23:21
@marcomorain marcomorain force-pushed the refactor-common-code branch from b558ce3 to 820cd83 Compare July 2, 2018 23:26
@codecov-io
Copy link

codecov-io commented Jul 2, 2018

Codecov Report

Merging #12 into master will decrease coverage by 10.95%.
The diff coverage is 2.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #12       +/-   ##
===========================================
- Coverage   33.08%   22.13%   -10.96%     
===========================================
  Files           9        9               
  Lines         535      488       -47     
===========================================
- Hits          177      108       -69     
- Misses        342      366       +24     
+ Partials       16       14        -2
Impacted Files Coverage Δ
cmd/collapse.go 0% <0%> (-16.67%) ⬇️
cmd/config.go 0% <0%> (-4.77%) ⬇️
cmd/query.go 0% <0%> (ø) ⬆️
cmd/configure.go 0% <0%> (-3.18%) ⬇️
cmd/orb.go 0% <0%> (-20.99%) ⬇️
cmd/diagnostic.go 0% <0%> (ø) ⬆️
cmd/root.go 22% <7.4%> (-54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249964...a5a853a. Read the comment docs.

@marcomorain marcomorain merged commit 3fa5416 into master Jul 4, 2018
@marcomorain marcomorain deleted the refactor-common-code branch July 4, 2018 12:31
@marcomorain
Copy link
Contributor Author

@zzak one to look at at your lesiure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants