Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIRCLE-12198] Update instructions circleci-beta->circleci-cli #17

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

hannahhenderson
Copy link
Contributor

@hannahhenderson hannahhenderson commented Jul 9, 2018

Paired with @eric-hu

This card isn't technically part of CIRCLE-12198, but it has a fair amount of overlap.

README.md Outdated
```

> You could also copy the query above, and run it directly from your Clipboard `pbpaste | circleci-cli query`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mac specific but probably okay (linux would be xclip -sel clipboard -o | circleci-cli query)

@hannahhenderson hannahhenderson changed the title Update instructions circleci-beta->circleci-cli [CIRCLE-12198] Update instructions circleci-beta->circleci-cli Jul 9, 2018
@hannahhenderson hannahhenderson force-pushed the hannahhenderson-patch-1 branch from bfc4f16 to 35ab374 Compare July 9, 2018 18:44
README.md Outdated
$ circleci configure
```

Accept the provided default `CircleCI API End Point`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't realize this was a prompt. I thought it printed out only.

In this case, maybe the instructions should instruct Server customers to use their Server address (i.e. circleci.my-org.com)

@hannahhenderson hannahhenderson force-pushed the hannahhenderson-patch-1 branch from 35ab374 to 7c712ce Compare July 9, 2018 21:07
@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #17   +/-   ##
======================================
  Coverage    43.4%   43.4%           
======================================
  Files          10      10           
  Lines         622     622           
======================================
  Hits          270     270           
  Misses        330     330           
  Partials       22      22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f9d52...fe4c21c. Read the comment docs.

@hannahhenderson hannahhenderson merged commit 8c28b7a into master Jul 9, 2018
@hannahhenderson hannahhenderson deleted the hannahhenderson-patch-1 branch July 9, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants