-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile tidy up #20
Makefile tidy up #20
Conversation
.circleci/config.yml
Outdated
@@ -34,7 +34,7 @@ jobs: | |||
CGO_ENABLED: 0 | |||
steps: | |||
- checkout | |||
- run: gometalinter ./... | |||
- run: make lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That image supinf/gometalinter
doesn't have make installed :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boo 🙈
Makefile
Outdated
.PHONY: build-all | ||
build-all: $(BUILD_DIR)/darwin/amd64/$(EXECUTABLE) $(BUILD_DIR)/linux/amd64/$(EXECUTABLE) | ||
build/%/amd64/circleci: always | ||
GOOS=$* GOARCH=amd64 go build -v -o $@ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding this correctly, will build both linux and mac binaries every time?
For some convenience, we wanted make
to just build the current OS's binary to save some time.
Updated @zzak to add single build back in. |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
======================================
Coverage 43.4% 43.4%
======================================
Files 10 10
Lines 622 622
======================================
Hits 270 270
Misses 330 330
Partials 22 22 Continue to review full report at Codecov.
|
@marcomorain
|
I'm calling |
Anything holding up this merge now? |
No description provided.