Add version command #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomorain
force-pushed
the
version-command
branch
2 times, most recently
from
c770198 to
255052f
Compare
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
+ Coverage 41.34% 41.6% +0.25%
=========================================
Files 10 11 +1
Lines 653 661 +8
=========================================
+ Hits 270 275 +5
- Misses 361 363 +2
- Partials 22 23 +1
Continue to review full report at Codecov.
|
marcomorain
force-pushed
the
version-command
branch
3 times, most recently
from
964395c to
fb368a6
Compare
endocrimes
approved these changes
Jul 17, 2018
.goreleaser.yml
Outdated
| @@ -15,3 +15,5 @@ builds: | |||
| - linux | |||
| goarch: | |||
| - amd64 | |||
| ldflags: | |||
| - -s -w -X version.Version={{.Version}} -X version.Commit={{.Commit}} | |||
There was a problem hiding this comment.
You may want to add a comment here explaining why you add -s and -w with a link to https://golang.org/cmd/link/
marcomorain
force-pushed
the
version-command
branch
from
fb368a6 to
a0beed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.