Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable query test and fix it #3

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Re-enable query test and fix it #3

merged 1 commit into from
Jun 22, 2018

Conversation

zzak
Copy link
Contributor

@zzak zzak commented Jun 22, 2018 •
edited
Loading

This test was originally broken here:
1eea784

We stopped using Prettify in collapse here:
980eb71

This means the query command is the only user of Prettify so we can change it back.

@codecov-io
Copy link

codecov-io commented Jun 22, 2018 •
edited
Loading

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #3   +/-   ##
======================================
  Coverage    37.2%   37.2%           
======================================
  Files           8       8           
  Lines         379     379           
======================================
  Hits          141     141           
  Misses        222     222           
  Partials       16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8a318...d6897de. Read the comment docs.

dcarley
dcarley approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@dcarley dcarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to include a note in the commit message that we stopped using Prettyify the other way for collapse in 980eb71

Re-enable query test and fix it
d6897de 
This test was originally broken here:
1eea784

We stopped using Prettify in `collapse` here:
980eb71

This means the `query` command is the only user of Prettify so we can
change it back.
@zzak zzak force-pushed the enable-query-test branch from cf5703b to d6897de Compare June 22, 2018 09:56
@zzak zzak merged commit b859803 into master Jun 22, 2018
@zzak zzak deleted the enable-query-test branch June 22, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcarley dcarley dcarley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzak @codecov-io @dcarley