Local expansion #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
+ Coverage 37.66% 38.27% +0.6%
=========================================
Files 8 8
Lines 377 371 -6
=========================================
Hits 142 142
+ Misses 219 213 -6
Partials 16 16
Continue to review full report at Codecov.
|
zzak
reviewed
Jun 22, 2018
| @@ -11,7 +11,7 @@ workflows: | |||
| requires: | |||
| - test | |||
| - coverage | |||
| # - lint disable lint check for now | |||
| - lint | |||
marcomorain
force-pushed
the
expand
branch
3 times, most recently
from
0f8185b to
77217d2
Compare
- There was a bug with creating the config file locally when it didn't exist - fix that. - Re-enable the lint job in CI. - Write the two config jobs in terms of a common function to reduce code duplication. - User our GraphQL client to do auth headers
|
Can this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.