Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "analytics events added" from PR template #709

Merged
merged 1 commit into from
May 19, 2022

Conversation

joeyorlando
Copy link
Contributor

Also some markdown auto-formatting changes that got applied.

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

Follow-up PR on #708 to remove "Analytics Events added" section

Rationale

=========

See above

Considerations

==============

N/A

Analytics Events Added

======================

N/A

Screenshots

============

N/A

Also some markdown auto-formatting changes that got applied.
@joeyorlando joeyorlando force-pushed the modify-pull-request-template branch from 0593247 to 2922e6c Compare May 19, 2022 15:30
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #709 (2922e6c) into master (5e6ca98) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   28.82%   28.82%           
=======================================
  Files          42       42           
  Lines        4860     4860           
=======================================
  Hits         1401     1401           
  Misses       3261     3261           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6ca98...2922e6c. Read the comment docs.

@joeyorlando joeyorlando merged commit 7c05b67 into master May 19, 2022
@joeyorlando joeyorlando deleted the modify-pull-request-template branch May 19, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants