Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase http client timeout to 60s #733

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

ruben1
Copy link
Contributor

@ruben1 ruben1 commented Jun 7, 2022

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

  • Increase http client timeout to 60s

Rationale

Should help with timeouts that have been seen in /api/v2/context/* 95th/max requests causing job flakiness for some users

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #733 (bf986a0) into master (e96ff59) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   28.50%   28.50%           
=======================================
  Files          42       42           
  Lines        4925     4925           
=======================================
  Hits         1404     1404           
  Misses       3323     3323           
  Partials      198      198           
Impacted Files Coverage Δ
settings/settings.go 31.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96ff59...bf986a0. Read the comment docs.

@ruben1 ruben1 marked this pull request as ready for review June 7, 2022 10:55
@ruben1 ruben1 requested a review from a team as a code owner June 7, 2022 10:55
@ruben1 ruben1 merged commit f5ffef7 into master Jun 7, 2022
@ruben1 ruben1 deleted the http-client-increase-timeout-1 branch June 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants