-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECENG-582] Make policy decisions locally #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-connect
changed the base branch from
master
to
SECENG-600-remote-policy-decision
June 28, 2022 02:28
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 31.59% 31.81% +0.21%
==========================================
Files 44 44
Lines 5295 5322 +27
==========================================
+ Hits 1673 1693 +20
- Misses 3376 3379 +3
- Partials 246 250 +4
Continue to review full report at Codecov.
|
This reverts commit 9a533d1.
…' into SECENG-582-make-decision-locally
davidmdm
reviewed
Jun 28, 2022
davidmdm
reviewed
Jun 28, 2022
davidmdm
reviewed
Jun 28, 2022
davidmdm
approved these changes
Jun 29, 2022
corinnesollows
requested changes
Jun 29, 2022
corinnesollows
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Changes
=======
Rationale
=========
The current implementation of decide subcommand performs policy decision using policy-service
This PR extends decide subcommand to perform policy evaluation locally using imported circle-policy-agent
Considerations
==============