update go.mod to declare go1.18 and updated CI to use Go 1.18 for tests #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 31.59% 31.59%
=======================================
Files 44 44
Lines 5295 5295
=======================================
Hits 1673 1673
Misses 3376 3376
Partials 246 246 Continue to review full report at Codecov.
|
sagar-connect
approved these changes
Jun 28, 2022
| @@ -680,7 +680,7 @@ The following orb versions already exist: | |||
| ` | |||
| actual, err := ioutil.ReadAll(&b) | |||
| Expect(err).ShouldNot(HaveOccurred()) | |||
| Expect(fmt.Sprintf("%s", actual)).To(Equal(expOutput)) | |||
| Expect(string(actual)).To(Equal(expOutput)) | |||
corinnesollows
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Changes
Rationale
Some dependencies require go 1.17 and greater. Because we were running CI with versions using go1.13 we were unable to use dependencies that required features from versions newer than 1.13.
Since go1.18 is latest version and go is backwards compatible we choose this new version for our update.