Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runner team to CODEOWNERS of runner packages #746

Merged

Conversation

christian-stephen
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Add Runner team to CODEOWNERS of runner packages

Rationale

=========

The Runner team would like to take partial ownership of the portions of the CLI that are for administering Self-Hosted Runners.

Considerations

==============

N/A

Screenshots

============

N/A

@christian-stephen christian-stephen requested a review from a team July 6, 2022 15:24
@christian-stephen christian-stephen marked this pull request as ready for review July 6, 2022 15:26
@christian-stephen christian-stephen requested a review from a team as a code owner July 6, 2022 15:26
@christian-stephen christian-stephen force-pushed the cs/own-runner branch 2 times, most recently from f6a33ae to b582071 Compare July 6, 2022 15:40
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #746 (d17ebe0) into master (655d065) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          44       44           
  Lines        5331     5331           
=======================================
  Hits         1693     1693           
  Misses       3388     3388           
  Partials      250      250           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655d065...d17ebe0. Read the comment docs.

Copy link
Contributor

@corinnesollows corinnesollows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're taking ownership of the runner files, you can remove us (@CircleCO-Public/Extensibility)
This way future PR Reviews go to the runner team and not us. 😄

@christian-stephen christian-stephen merged commit 830e7ff into CircleCI-Public:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants