Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECENG-676] added 'status' filter to decision logs fetch command #753

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

sagar-connect
Copy link
Contributor

@sagar-connect sagar-connect commented Jul 14, 2022

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • added 'status' filter to decision logs fetch command
  • updated unit-tests
  • updated usage tests golden data

Rationale

=========

This is in continuation to: https://github.com/circleci/policy-service/pull/147

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #753 (ff3858a) into master (f848adb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   31.88%   31.91%   +0.03%     
==========================================
  Files          44       44              
  Lines        5323     5326       +3     
==========================================
+ Hits         1697     1700       +3     
  Misses       3382     3382              
  Partials      244      244              
Impacted Files Coverage Δ
api/policy/policy.go 65.86% <100.00%> (+0.41%) ⬆️
cmd/policy/policy.go 82.02% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f848adb...ff3858a. Read the comment docs.

@sagar-connect sagar-connect marked this pull request as ready for review July 14, 2022 14:27
@sagar-connect sagar-connect requested a review from a team as a code owner July 14, 2022 14:27
@sagar-connect sagar-connect merged commit e4216bd into master Jul 14, 2022
@sagar-connect sagar-connect deleted the SECENG-676-status-filter-policy-logs branch July 14, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants