Added examples for policy commands #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-connect
changed the title
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
=======================================
Coverage 32.77% 32.77%
=======================================
Files 46 46
Lines 5415 5415
=======================================
Hits 1775 1775
Misses 3387 3387
Partials 253 253
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
davidmdm
reviewed
Aug 20, 2022
cmd/policy/policy.go
Outdated
| @@ -83,7 +83,7 @@ func NewCommand(config *settings.Config, preRunE validator.Validator) *cobra.Com | |||
| return nil | |||
| }, | |||
| Args: cobra.ExactArgs(1), | |||
| Example: `policy push ./policy_bundle_dir_path --owner-id 462d67f8-b232-4da4-a7de-0c86dd667d3f --context config`, | |||
| Example: `policy push ./config --owner-id 462d67f8-b232-4da4-a7de-0c86dd667d3f`, | |||
There was a problem hiding this comment.
The folder to be pushed being called config is confusing.
Policy push ./policies seems better.
There's the confusion between the context config and the folder config...
cmd/policy/policy.go
Outdated
| @@ -117,7 +117,8 @@ func NewCommand(config *settings.Config, preRunE validator.Validator) *cobra.Com | |||
|
|
|||
| return prettyJSONEncoder(cmd.OutOrStdout()).Encode(diff) | |||
| }, | |||
| Args: cobra.ExactArgs(1), | |||
| Args: cobra.ExactArgs(1), | |||
| Example: `policy diff ./config --owner-id 462d67f8-b232-4da4-a7de-0c86dd667d3f`, | |||
cmd/policy/policy.go
Outdated
| @@ -356,7 +358,8 @@ func NewCommand(config *settings.Config, preRunE validator.Validator) *cobra.Com | |||
|
|
|||
| return nil | |||
| }, | |||
| Args: cobra.ExactArgs(1), | |||
| Args: cobra.ExactArgs(1), | |||
| Example: `policy eval ./config --input ./.circleci/config.yml`, | |||
davidmdm
approved these changes
Aug 20, 2022
eddiewebb
reviewed
Aug 22, 2022
| @@ -264,13 +265,13 @@ func NewCommand(config *settings.Config, preRunE validator.Validator) *cobra.Com | |||
|
|
|||
| cmd := &cobra.Command{ | |||
| Short: "make a decision", | |||
| Use: "decide", | |||
| Use: "decide [policy_file_or_dir_path]", | |||
eddiewebb
reviewed
Aug 22, 2022
threepipes
pushed a commit
to threepipes/circleci-cli
that referenced
this pull request
Sep 22, 2022
* added examples for policy commands * updated example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Changes
=======