Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list project environment variable subcommand (one of commands to manage projects) #770

Merged
merged 22 commits into from
Feb 6, 2023

Conversation

threepipes
Copy link
Contributor

@threepipes threepipes commented Aug 20, 2022

Checklist

=========

Changes

=======

  • Add a project command
    • Add a subcommand to list project environment variables
      • circleci project secret list <vcs> <org> <project>

Rationale

=========

This PR partially solves #652.
Currently, CircleCI CLI does not have the ability to manage Projects.
This change enables one of these abilities and makes it easier to write the rest subcommands.

Considerations

==============

I will add other subcommands to manage project environment variables like create and delete.

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@threepipes threepipes changed the title Add commands to manage projects Add one of commands to manage projects Aug 20, 2022
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c849191). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d9b35dd differs from pull request most recent head a3f7e7d. Consider uploading reports for the commit a3f7e7d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage        ?   33.64%           
=======================================
  Files           ?       49           
  Lines           ?     5495           
  Branches        ?        0           
=======================================
  Hits            ?     1849           
  Misses          ?     3390           
  Partials        ?      256           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

api/rest/client.go Outdated Show resolved Hide resolved
- `circleci project list-secrets`

Other changes:
- Replace a request header `Accept-Type` with `Accept`
@threepipes threepipes marked this pull request as ready for review August 20, 2022 14:13
@threepipes threepipes requested review from a team as code owners August 20, 2022 14:13
@threepipes threepipes changed the title Add one of commands to manage projects Add list project environment variable subcommand (one of commands to manage projects) Aug 21, 2022
@threepipes
Copy link
Contributor Author

@CircleCI-Public/Extensibility Could you review this PR?
As I am new to this project as a contributor, please let me know if there is anything I have to do for your review.

@corinnesollows
Copy link
Contributor

Hello @threepipes This PR is large, could it possibly be broken down into smaller PRs. ie: Accept-Type in one PR and project command in a separate one? Thank you

@threepipes
Copy link
Contributor Author

@corinnesollows Thank you for your comment and advice.
Sure, I will make a PR for the Accept-Type header.
I will let this PR be as of now because the Accept-Type change is required for the current implementation. So I hope you will check this one after checking the Accept-Type one.

@threepipes
Copy link
Contributor Author

The header changes are extracted: #784

@threepipes
Copy link
Contributor Author

@corinnesollows
Thank you for your approval of #784.
This PR no longer contains the Accept-Type header changes.
If there are any more requirements, feel free to let me know.

@flanger001
Copy link

It would be extremely tight if this could get some attention @CircleCI-Public/Extensibility @corinnesollows

@threepipes threepipes requested a review from a team as a code owner February 6, 2023 01:25
@JulesFaucherre JulesFaucherre merged commit 5cbf90e into CircleCI-Public:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants