Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECENG-821] Get policy decision log by decision id #776

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

sagar-connect
Copy link
Contributor

@sagar-connect sagar-connect commented Sep 7, 2022

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Added support for decisionID argument in existing policy logs command
  • Added support for --policy-bundle flag in existing policy logs command
  • Updated help text
  • Updated unit-tests

Rationale

=========

The new command will allow the users to fetch policy bundle associated with policy decision log

@sagar-connect sagar-connect marked this pull request as ready for review September 7, 2022 18:28
@sagar-connect sagar-connect requested a review from a team as a code owner September 7, 2022 18:28
@sagar-connect sagar-connect requested review from davidmdm, davidmparrott and vallieres and removed request for a team September 7, 2022 18:28
api/policy/policy.go Outdated Show resolved Hide resolved
Copy link
Contributor

@davidmdm davidmdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments. Approving so as to not be blocking, but I would urge to think on them, or gather find another person to either way in on some of my more subjective opinions... @davidmparrott @vallieres

Copy link

@vallieres vallieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LGTM

@sagar-connect sagar-connect merged commit 56e791b into master Sep 9, 2022
@sagar-connect sagar-connect deleted the SECENG-821-get-decision-by-decision-id branch September 9, 2022 15:40
threepipes pushed a commit to threepipes/circleci-cli that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants