Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charm Prompt changes #781

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Charm Prompt changes #781

merged 2 commits into from
Sep 19, 2022

Conversation

corinnesollows
Copy link
Contributor

@corinnesollows corinnesollows commented Sep 19, 2022 •
edited
Loading

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Prompts are interactive, UI improved.
  • Fixes grammer as well on y/N prompt

Rationale

=========

Changes made in previous hack week

Considerations

==============

This small change has been extracted from other branches to break down the project

Screenshots

============

Be Screen Shot 2022-09-19 at 9 58 30 AM fore

After

Screen Shot 2022-09-19 at 9 57 13 AM

@corinnesollows corinnesollows requested a review from a team as a code owner September 19, 2022 12:59
@corinnesollows
Merge branch 'master' of github.com:CircleCI-Public/circleci-cli into…
c64b2af 
… hack-week-prompt-i

# Conflicts:
#	go.mod
#	go.sum
nramabad
nramabad approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@nramabad nramabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corinnesollows corinnesollows merged commit 0f1ff57 into master Sep 19, 2022
@corinnesollows corinnesollows deleted the hack-week-prompt-i branch September 19, 2022 14:19
threepipes pushed a commit to threepipes/circleci-cli that referenced this pull request Sep 22, 2022
@corinnesollows
Charm Prompt changes (CircleCI-Public#781)
ea69d24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nramabad nramabad nramabad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corinnesollows @nramabad