Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates away from API-Service and calls orb-service directly for config compilation and validation #792

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

elliotforbes
Copy link
Contributor

@elliotforbes elliotforbes commented Oct 4, 2022

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • [x]I have read Contribution Guidelines.

Changes

=======

  • Calls the Orb-Service directly as opposed to proxying config compilation + validation through the api-service.
  • Now includes the appropriate OwnerID to allow for private orb fetching

Rationale

=========

We are looking to remove config-compilation from the api-service.

Considerations

==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

Screenshots

============

Before

Image or [gif](https://giphy.com/apps/giphycapture)

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@elliotforbes elliotforbes requested a review from a team as a code owner October 4, 2022 11:03
@elliotforbes elliotforbes changed the title Migrates away from API-Service and calls orb-service directly Migrates away from API-Service and calls orb-service directly for config compilation and validation Oct 4, 2022
Copy link
Contributor

@corinnesollows corinnesollows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see more function title comments, but its not a required fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants