Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding to PR Template #799

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Adding to PR Template #799

merged 2 commits into from
Oct 17, 2022

Conversation

corinnesollows
Copy link
Contributor

@corinnesollows corinnesollows commented Oct 11, 2022 •
edited
Loading

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Added two items to the PR Template Checklist for Internal staff

Rationale

=========

EXT-652

Considerations

==============

I added a sub header titles "Internal" as these requirements only affect internal staff

@corinnesollows corinnesollows requested a review from a team as a code owner October 11, 2022 19:00
@corinnesollows corinnesollows merged commit 5ff92b4 into master Oct 17, 2022
@corinnesollows corinnesollows deleted the EXT-652-PR-updates branch October 17, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am-bui am-bui am-bui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corinnesollows @am-bui