Orb validation and expansion. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-hu
reviewed
Jun 29, 2018
| @@ -24,3 +27,27 @@ func TestCmd(t *testing.T) { | |||
| RegisterFailHandler(Fail) | |||
| RunSpecs(t, "Cmd Suite") | |||
| } | |||
|
|
|||
| // Test helpers | |||
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 35.49% 33.08% -2.41%
==========================================
Files 9 9
Lines 448 535 +87
==========================================
+ Hits 159 177 +18
- Misses 273 342 +69
Partials 16 16
Continue to review full report at Codecov.
|
|
LGTM Messaged Brady with a nit about pulling out more common test setup into localized |
eric-hu
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following orb commands to the cli:
circleci-cli orb expandcircleci-cli orb validate